A theoretical solution is presented for the determination of the combinations of direct axial stress and torsion which cause thin-walled cylinders with either simply supported or clamped edges to buckle. This theoretical solution is used in conjunction with available test data to develop empirical curves and formulas for use in design. Comparisons are made with theoretical and empirical solutions obtained in other investigations